-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check_only template for publishing platform integrations #18596
add check_only template for publishing platform integrations #18596
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
9bd0cf3
to
cafad04
Compare
cafad04
to
e469a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on a cursory glance looks good!
6914a34
to
46c6a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for docs
…lishing_platform_integrations
* add agent_check template for publishing platform integrations * add option to skip manifest checks * add changelog entry * remove unused import --------- Co-authored-by: HadhemiDD <[email protected]> d4157fc
Adds a new
check_only
option forddev create
- this option enables the creation of agent checks when the manifest already exists and prefills the appropriate information from the manifest. It also includes a--skip-manifest
flag which will prompt disable checking for the manifest and using its fields, but still avoid creating the non-agent check files that are typically required. The intention of this is to be used with publishing platform, where the non-code portions of the integration have already been created in github or otherwise.Test plan
Happy path:
ddev create -t check_only my_integration
No manifest:
ddev create -t check_only my_integration --skip-manifest
Regression test:
ddev create -t check my_integration
ECOS-1617